[BR-1794]: Add rate limit retry mechanism with exponential backoff by terrerox · Pull Request #1834 · internxt/drive-web

terrerox · 2026-02-03T04:27:40Z

Description

Implement retry utility to handle 429 rate limit errors with configurable backoff strategy, extract rate limit info
from response headers, and apply it to public shared folder content requests to improve reliability under rate
limiting conditions.

Related Issues

Related Pull Requests

Checklist

Changes have been tested locally.
Unit tests have been written or updated as necessary.
The code adheres to the repository's coding standards.
Relevant documentation has been added or updated.
No new warnings or errors have been introduced.
SonarCloud issues have been reviewed and addressed.
QA Passed

Testing Process

Additional Notes

Implement retry utility to handle 429 rate limit errors with configurable backoff strategy, extract rate limit info from response headers, and apply it to public shared folder content requests to improve reliability under rate limiting conditions.

cloudflare-workers-and-pages · 2026-02-03T04:27:49Z

Deploying drive-web with Cloudflare Pages

Latest commit:	`34d5f3b`
Status:	✅ Deploy successful!
Preview URL:	https://82de3e28.drive-web.pages.dev
Branch Preview URL:	https://feature-retry-with-backoff.drive-web.pages.dev

View logs

CandelR

Is this accompanied by some kind of visual information for the user? I don't see the point of this PR from the user's point of view, as they will be waiting at least 60 seconds without knowing what is happening, which is an enormous amount of time.

CandelR · 2026-02-03T07:40:40Z

src/app/network/retry-with-rate-limit.ts

+  return typeof error === 'object' && error !== null;
+}
+
+function isRateLimitError(error: unknown): boolean {


Use arrow functions to be consistent with rest of the codebase

CandelR · 2026-02-03T07:40:42Z

src/app/network/retry-with-rate-limit.ts

+  return (
+    error.status === 429 ||
+    error.statusCode === 429 ||
+    error.response?.status === 429 ||


If I remember correctly, there are status codes, use them or add this one if it is not there

src/app/network/retry-with-rate-limit.ts

CandelR · 2026-02-03T07:40:46Z

src/app/network/retry-with-rate-limit.ts

+    return undefined;
+  }
+
+  const resetValueMs = Number.parseInt(headers['x-ratelimit-reset'], 10);


the unit that return the server is in miliseconds?

CandelR · 2026-02-03T07:40:48Z

src/app/network/retry-with-rate-limit.ts

+    }
+  }
+
+  throw new Error('Maximum retries exceeded');


Is this error reachable? Check it with tests

src/app/share/services/share.service.ts

CandelR · 2026-02-03T07:40:52Z

src/app/share/services/share.service.ts

+      maxRetries: 5,
+      maxDelay: 60000,
+      onRetry: (attempt, delay) => {
+        console.log(


maybe better use console warn if want to log the retry for when user records the console and send to us

CandelR · 2026-02-03T07:44:53Z

src/app/network/retry-with-rate-limit.ts

+  if (!isErrorWithStatus(error) || !error.headers) {
+    return undefined;
+  }


this is already checked in isRateLimitError, I think that never will reach this code

CandelR · 2026-02-03T07:46:01Z

src/app/network/retry-with-rate-limit.ts

+  };
+}
+
+export async function retryWithBackoff<T>(fn: () => Promise<T>, options: RetryOptions = {}): Promise<T> {


add jsdoc to this exported function

src/app/network/retry-with-rate-limit.ts

- Remove maxDelay option and related fallback logic - Simplify rate limit detection to only check status codes (429) - Update rate limit header from 'x-ratelimit-reset' to 'x-internxt-ratelimit-reset' - Remove limit and remaining fields from RateLimitInfo interface - Add user-facing toast notification on first retry attempt - Convert functions to arrow functions for consistency - Add HTTP_CODES.TOO_MANY_REQUESTS constant - Add JSDoc documentation to retryWithBackoff function - Add internationalization support for retry notification - Update tests to reflect new behavior and validate toast integration - Fix loop condition to prevent unreachable code

…stence

sg-gs · 2026-02-04T15:46:56Z

src/app/network/retry-with-rate-limit.ts

+
+      if (!hasShownRateLimitToast) {
+        hasShownRateLimitToast = true;
+        notificationsService.show({


I would not mix UI related things with pure logic like this function. Return something that allows the function consumer to determine if showing this notification or not proceeds

CandelR · 2026-02-05T08:50:12Z

src/app/i18n/locales/de.json

      "link-updated": "Linkeinstellungen aktualisiert",
      "link-deleted": "Link gelöscht",
-      "links-deleted": "Link(s) gelöscht"
+      "links-deleted": "Link(s) gelöscht",


Seems that here is missing error-deleting-links translation, can you add it? :)

CandelR · 2026-02-05T09:10:23Z

src/app/share/services/share.service.ts

+          hasShownRateLimitNotification = true;
+          notificationsService.show({
+            text: t('shared-links.toast.rate-limit-retry'),
+            type: ToastType.Warning,
+            duration: Infinity,
+          });


Move this out of the service, return the error, and handle it in the manager component of the UI to decide what to display. This way, we try to keep it clean. Even if there is a function with the notificationService in this service, we will try not to mix it up any further :)

sonarqubecloud · 2026-02-05T14:38:21Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

terrerox requested review from a team, CandelR and larryrider as code owners February 3, 2026 04:27

terrerox self-assigned this Feb 3, 2026

CandelR requested changes Feb 3, 2026

View reviewed changes

sg-gs requested changes Feb 3, 2026

View reviewed changes

src/app/network/retry-with-rate-limit.ts Outdated Show resolved Hide resolved

src/app/network/retry-with-rate-limit.ts Outdated Show resolved Hide resolved

src/app/network/retry-with-rate-limit.ts Outdated Show resolved Hide resolved

terrerox marked this pull request as draft February 4, 2026 03:49

refactor: Simplify rate limit retry mechanism and improve toast persi…

cd0f3ad

…stence

terrerox force-pushed the feature/retry-with-backoff branch from 52a8dc6 to cd0f3ad Compare February 4, 2026 15:16

terrerox marked this pull request as ready for review February 4, 2026 15:22

terrerox requested review from CandelR and sg-gs February 4, 2026 15:23

sg-gs reviewed Feb 4, 2026

View reviewed changes

terrerox requested a review from sg-gs February 4, 2026 16:38

refactor: Show rate limit notification only once per session

6b7760c

terrerox force-pushed the feature/retry-with-backoff branch from 56215d9 to 6b7760c Compare February 5, 2026 03:32

sg-gs approved these changes Feb 5, 2026

View reviewed changes

CandelR reviewed Feb 5, 2026

View reviewed changes

refactor: Move rate limit notification logic to UI layer

34d5f3b

CandelR approved these changes Feb 5, 2026

View reviewed changes

Conversation

terrerox commented Feb 3, 2026

Description

Related Issues

Related Pull Requests

Checklist

Testing Process

Additional Notes

Uh oh!

cloudflare-workers-and-pages bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying drive-web with Cloudflare Pages

Uh oh!

CandelR left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CandelR Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cloudflare-workers-and-pages bot commented Feb 3, 2026 •

edited

Loading

CandelR Feb 3, 2026 •

edited

Loading